kamilskoracki / CocoJumper

Character search, select and jump
https://marketplace.visualstudio.com/items?itemName=Coco.cocojumper
GNU General Public License v3.0
6 stars 1 forks source link

Better Integration with VsVim #32

Open CheesePizza100 opened 5 years ago

CheesePizza100 commented 5 years ago

Been testing out CocoJumper with VsVim. While it does seem to work for MultiSerach mode it is a bit clunky.

When in VsVim Normal mode I can invoke MultiSearch but I cannot start searching. After invoking the command I have to place VsVim into Insert mode and then I can search but sometimes pressing Enter will activate the "choosing" mode but pressing a key will not jump to desired location.

Kraviecc commented 5 years ago

Hi @CheesePizza100

thanks for testing out CocoJumper. We haven't been using vsvim but we have started investigating the issue. If you have any other clues for us, feel free to write an additional comment.

CheesePizza100 commented 5 years ago

This might be a good place to investigate, seems AceJump went through something similar:

https://github.com/jsturtevant/ace-jump/issues/3

Maybe the last 2 commits might be helpful? https://github.com/jsturtevant/ace-jump/pull/6/commits

It describes what I am experiencing. To be more precise with steps:

  1. Be in Normal mode in VsVim.
  2. Invoke CocoJumper MultiSearch command.
  3. Whatever keystrokes you entered are actually handled by VsVim.

Workaround:

  1. Be in Normal mode in VsVim.
  2. Invoke CocoJumper MultiSearch command.
  3. Type "i" key, this will put you in VsVim Insert mode.
  4. Start typing your search letters.
  5. Hit Enter twice.
  6. You will then jump to your target.
C485 commented 5 years ago

I looked into this problem and: VsVim uses more than one way of detecting key presses, i managed to make a workaround for first one, still need to work with second one. Fix with was made by ace-jump was basically a on/off switch for whole addon with is not a good idea

it may take w while