search

kamilwylegala / vue-tournament-bracket

Vue component for rendering single elimination tournament brackets.
50 stars 25 forks source link

Typescritpt support with vue3 #12

Open NicolasMelin opened 3 years ago

NicolasMelin commented 3 years ago

Hello,

I just want to know how use you module with typescript please ?

Thanks by advance.

Best regards

kamilwylegala commented 3 years ago

Hey Nicolas,

Unfortunately I don't have experience with TypeScript yet. I plan to introduce TypeScript in my projects, including vue-tournament-bracket but now I don't have time to play with it.

So answer is: I don't know.

Similar story for Vue3. Do you think it's possible to support both versions of Vue. I.e. v2 and v3?

Regards, Kamil.

NicolasMelin commented 3 years ago

Thanks for your response. I don't think it's possible to support both versions of vue2 and vue3 in a same version of your module.

kamilwylegala commented 3 years ago

OK it'd be an update to 3.0.0 of lib.

I can't commit to any deadline for updating to Vue 3. But I'll keep this issue open.

I need to read migration guidelines, then I can focus on update.

NicolasMelin commented 3 years ago

Ok no problem, tks for your responses ;).

luffynando commented 3 years ago

@kamilwylegala I already have a working version of this library in vue 3 with support for typescript and composition api, I would like to send it to you and give it a review.

kamilwylegala commented 3 years ago

@luffynando That'd be great!

Could you create pull request?

Thanks in advance!

luffynando commented 3 years ago

@kamilwylegala Sorry but i can´t create pull request, my base it's completely different from master, it´s not possible to support both versions of vue2 and vue3. I shared my repo with support vue3, I hope you can send me information on how to make this part of the main repo. https://github.com/luffynando/vue-tournament-bracket

kamilwylegala commented 3 years ago

Thanks for sharing. I'll take a look and see what are the differences.