Open maca opened 6 years ago
It's always nice to drop dependencies. Sinatra is very minimal and doesn't implement methods that Kaminari depends on. I was not part of the team when the padrino-helpers
gem was added in the first place, but my hunch is that some dependencies were added just to get things out the door. It would be greatly appreciated if you could contribute back to the community.
@yuki24 thanks for your reply, I couldn't get to get kaminari-sinatra
working with my app, I still don't know if it has to do with my use of faker
which injects i18n
gem. I will look further and see if I could find the time to attempt to replace the padrino-helpers
methods.
padrino-core-0.9.21
looks quite old. I wonder if that should be a more recent version, possibly the latest version otherwise some compatibility issue may arise.
Steps to resolve:
gem install padrino-core gem install padrino-helpers Go to kaminari-sinatra gem folder Find the folder called "Gemfiles" There are some .gemfile files Change gem 'padrino-helpers' ~> 0.12.0 for gem 'padrino-helpers'
End
I am not using padrino in my new Sinatra app. But including kaminari-sinatra attempts somehow to read translation files from padrino.
Is the padrino-helpers depencency necesary?
This is when I run my previously passing specs after adding kaminari-sinatra into my gemfile.