search

kaminaris / MaxDps

Other
22 stars 14 forks source link

Add support for LAB forks #3

Closed ls- closed 5 years ago

ls- commented 5 years ago

Sup o/

Some of my UI users use this addon, but my UI relies on my own fork of LAB. Yeah, yet another LAB fork, there's quite many these days.

So instead of hooking your FetchLibActionButton and UpdateButtonGlow methods or nagging you to add support for other forks, I decided to add RegisterLibActionButton method, so other people could register their LABs w/ your addon, so it could work w/ their buttons w/o any hassle.

Some time ago I did something similar for AdiButtonAuras. I rewrote all affected functions, primarily aforementioned FetchLibActionButton and UpdateButtonGlow. I also tried to follow your style, so it should look fine :D

Ah, and regarding UpdateButtonGlow, I fixed its logic, there's an issue where origShow's state wasn't saved across calls, so you could actually end up w/ it being noFunction or now nop, nop is a Blizz func. And it wasn't updated when you toggled the "Disable blizzard button glow" thingy. I also removed UpdateButtonGlow from PEW and moved it to EnableRotation. You could probably remove "experimental" from it, but keep it disabled by default 🤔

If you want, I can move all glow changes to their own PR.

pwilkowski commented 5 years ago

Im gonna test this thing out first