search

kamiyaa / joshuto

ranger-like terminal file manager written in Rust
https://crates.io/crates/joshuto
GNU Lesser General Public License v3.0
3.47k stars 154 forks source link

theme.toml does not parse hex colors #151

Closed Beethoven-n closed 2 years ago

Beethoven-n commented 2 years ago

str_to_color() in style.rs only has a method to parse Rgb values, when colors_transform has methods to convert hex colors into Rgb colors.

Before the Rgb parsing, it should be possible to convert a hex color into an Rgb with rgb.from_hex_str, then pass that into the Rgb parsing method. (there's probably a better way to do that)

kamiyaa commented 2 years ago

Shouldn't be too hard to implement. But currently, I'm a bit busy and probably won't get around to working on this at the moment

Beethoven-n commented 2 years ago

would've done a pull request about it if i was comfortable enough with rust to know that the way i thought it should be done was the correct way

kamiyaa commented 2 years ago

Closed via https://github.com/kamiyaa/joshuto/pull/154