Bug: "Failed to parse app config: If a file is missing" after closing joshuto

[BoolPurist]

Observation

When i close joshuto via q then i get following error message on the terminal:

Failed to parse app config: Configuration file bookmarks.toml not found

As soon as I place a bookmarks.toml file in the config folder under ~/.config/joshuto, the error message stops appearing after closing joshuto via q.

Why i think that this is a bug

Seems odd to me since according to section of docs there is no mentioning that bookmarks.toml is required.

Used joshuto verson

joshuto-0.9.4

[BoolPurist]

On my laptop I started joshuto without any of the toml config files. Then I get even more error messages upon closing joshuto.

Failed to parse app config: Configuration file joshuto.toml not found
Failed to parse keymap config: Configuration file keymap.toml not found
Failed to parse theme config: Configuration file theme.toml not found
Failed to parse mimetype config: Configuration file mimetype.toml not found
Failed to parse app config: Configuration file bookmarks.toml not found

[DLFW]

I would not rate this a bug. It's intended and just Joshuto's message when a config file does not exist. Joshuto still loads the defaults for the missing config files and starts and works as expected.

However, I would agree that the message sounds too "severe". And Joshuto should maybe just silently ignore a missing config file if not in some kind of "verbose mode". I guess it would make sense to distinguish a real "parse failure" and a missing file. The first is worth a message in any case.

[kamiyaa]

Fixed in 501ad8ce356e283757ba159e06bdcbeb695ff676 Joshuto should only throw errors related to the format of the file if it exists. Otherwise, it will silently fail and load default config

[BoolPurist]

The error message does not appear anymore for the missing bookmarks.toml upon closing joshuto on the commit https://github.com/kamiyaa/joshuto/commit/501ad8ce356e283757ba159e06bdcbeb695ff676. However for the 4 other missing toml files, no toml file found, the error messages still occur upon closing the app.

Failed to parse app config: Configuration file joshuto.toml not found
Failed to parse keymap config: Configuration file keymap.toml not found
Failed to parse theme config: Configuration file theme.toml not found
Failed to parse mimetype config: Configuration file mimetype.toml not found

[kamiyaa]

Whoops, should be fixed with f2c9a05dae3ce162b7206ba0760af294c6607c34 now

[BoolPurist]

Jup now it is fixed