preview_script required for preview_shown_hook_script?

kamiyaa / joshuto

ranger-like terminal file manager written in Rust

https://crates.io/crates/joshuto

GNU Lesser General Public License v3.0

3.37k stars 148 forks source link

preview_script required for preview_shown_hook_script? #434

Closed EvanCarroll closed 9 months ago

EvanCarroll commented 10 months ago

It's not at all clear to me that,

if you don't have a preview_script that exists and is +x and returns 0, you can't get a preview_shown_hook_script working.
why my preview_removed_hook_script doesn't work.

Now I know it, but I think the docs should reflect this very clearly.

DLFW commented 10 months ago

Hi! I will add a note in the docs. Here is a proposal (the ❗-section). Do you think that gives more clarity? Sorry when it sound somewhat clumsy. I'm not an English native speaker (obviously). I'm always struggling with the documentation...

DLFW commented 9 months ago

@EvanCarroll : can this be closed? Are you still missing something or do you have any proposal?