kamiyaa / joshuto

ranger-like terminal file manager written in Rust
https://crates.io/crates/joshuto
GNU Lesser General Public License v3.0
3.47k stars 154 forks source link

Joshuto exits with error on "open_with" action attempt without a target #546

Closed steven-reina closed 4 months ago

steven-reina commented 5 months ago

Description:

Using joshuto, when attempting to open an empty target (on an empty directory) with an arbitrary command (using the native :open_with command), it perhaps handles this error case by exiting joshuto altogether, with a 101 exit code. This error is reproducible, regardless of the platform it's run on.

System information:

How to reproduce:

Expectation:

I don't believe this to be the intended way to handle such case, so it should simply print some warning in the information/command bar, or maybe nothing at all, as is the case for the :open command under the same circumstances, as of right now.

kamiyaa commented 4 months ago

Thanks for the bug report!

Fixed in 235f339e1cae6421651bb3ab1b5fcac512882c19