search

kamlekar / HTML-Skinning-Boilerplate

A Boilerplate/Scaffold to do HTML skinning faster for Websites.
15 stars 6 forks source link

Skeleton structure improved #19

Closed ghost closed 8 years ago

ghost commented 8 years ago

I hope all changes are visible now and are understandable.

ghost commented 8 years ago

Also as I've mentioned earlier, I'm new for github and I don't know how to place two files in one pull request, sorry.

kamlekar commented 8 years ago

yeah no problem. Looks good to me but there is only one problem, the comments are SHOUTING :). Anyway, I will take your request and do require changes. Thanks.

ghost commented 8 years ago

Sorry for this but I should distinct them from yours in some way. Hope you understand my suggestions, it's the main thing. Also, I have other points for improvements. Do you have time to discuss them here?

kamlekar commented 8 years ago

Yes sure, I can reply whenever I get time. if you have any suggestions, please add as a new issue so that we can keep track of things. Also, no need of trying to distinct the comments or code from next time. Once again, thanks for contributing :)

kamlekar commented 8 years ago

In these changes, you removed SVG sprite loading. Please check section/_head.html.