search

kamlekar / HTML-Skinning-Boilerplate

A Boilerplate/Scaffold to do HTML skinning faster for Websites.
15 stars 6 forks source link

Rename project folders #20

Closed ghost closed 8 years ago

ghost commented 8 years ago

Ok, now we have this folders structure in templates-pre: | templates-pre |---sections |---variables |---index.html

So imagine we need to create folders in our site, for adding a shop for example so structure will be: | templates-pre |---sections |---shop | |---shop-index.html |---variables |---index.html

So it's better to rename templating folders with underscore prefix to distinct where is site and where are templating: | templates-pre |---_sections |---_variables |---shop | |---shop-index.html |---index.html

Ok? If ok, next problem will appear...

kamlekar commented 8 years ago

Currently, the naming conventions for the folders are quite poor. I will consider your suggestion once I rename those folders to some good names. Until then I will keep this issue as open. Thanks.

ghost commented 8 years ago

Please look at my variant for structure: project |--html (instead of templates) |--|--_components |--|--_layout (instead of section) |--|--index.html |--scss (sass) |--svg (bundle svgs) |--www (instead of site) |--|--assets |--|--data gulpfile.js README.md

Advantage of this is that alphabetical order corresponds with ierarchy of importance - first we need to edit html templates, then sass, then svgs, and getting output in www folder.

kamlekar commented 8 years ago

It seems you are a .net dev. The directory looks familiar to .net's directory :). I am actually planning to refer the directory structure of jekyll. https://github.com/jekyll/jekyll

ghost commented 8 years ago

It's just a self-explaining structure, but choice is for you of course...

kamlekar commented 8 years ago

No, I am not trying to be biased here. The thing is if I go with .net structure, non .net devs can't understand the structure. The Jekyll is a globally known structure so I am referring it. I hope you can understand. But if you have any other globally known directory structures, do please share it.

kamlekar commented 8 years ago

Please check this branch where I added these changes. Let me know if you have any suggestions. Thanks.

ghost commented 8 years ago

I didn't mean underscore prefix for overall folders, just for templates (_sections / _variables) - which contain files that won't be compiled. I looked at Jekyll - they have such logic in "site" folder.

kamlekar commented 8 years ago

Yup you are right. will do changes accordingly and update the branch.

kamlekar commented 8 years ago

Check the updated Change-dir branch. Somehow the branch repo is failing. I suspect even the master branch is failing. need to check it.

ghost commented 8 years ago

Normal now.