search

kamlekar / HTML-Skinning-Boilerplate

A Boilerplate/Scaffold to do HTML skinning faster for Websites.
15 stars 6 forks source link

Add variables for paths, added 'gulp-data' code #26

Closed ghost closed 8 years ago

ghost commented 8 years ago

Set paths to base templates and sources through variables. Added 'gulp-data' for adding data.json to site. You need to create 'data.json' file in site/data/ folder

kamlekar commented 8 years ago

Hi @rustemgareev did you check? is it working fine?

ghost commented 8 years ago

Hi, yes I checked it (except bundle-svgs). sass / js / htmls work fine. The only possible mistakes can be with mispellings (I haven't copy/pasted from notepad++, I inputed directly in browser github). But overall this works.

kamlekar commented 8 years ago

Ok. There is a small change. Keep "assets/" path in a separate variable. So that when user changes this path, all paths changes automatically. reusable concept. You can edit this PR by visiting "Files changed" tab, I think. and also, you added gulp-data but it was never added in package.json. (better to remove that line, we can see later). Please work with patience with me :)

ghost commented 8 years ago

I sent package.json with "gulp-data" in another pull request (I still don't know how to edit multiple files in one pull request). As for "assets" in separate variable - I don't think. For example, people can have this structure: |site |--assets |--|--css |--|--js |--shop |--data |--images

ghost commented 8 years ago

So I don't think users will have trouble to change 20 characters in code.

kamlekar commented 8 years ago

ok :+1: will merge this once I fix the current issue which I am struggling to fix from morning.