kamleshcropin / uimafit

Automatically exported from code.google.com/p/uimafit
0 stars 0 forks source link

JCasUtil.isCovered() is named somewhat confusing #90

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
The semantics of this method is that given a certain annotation it checks 
whether it covers any other annotation of a certain type. At least for me, the 
single annotation is the "subject" and the type is the "object", so I read 
"instance of annotation is covered by some annotation of type" which is *not* 
what the method does.
It is rather "instance of annotation covers some annotation of type".
Is it only me, or should that be better renamed?

Original issue reported on code.google.com by torsten....@gmail.com on 6 May 2011 at 1:36

GoogleCodeExporter commented 8 years ago
I agree it's a little confusing. I probably would have named it "covers" or 
"contains".

Original comment by steven.b...@gmail.com on 7 May 2011 at 8:02

GoogleCodeExporter commented 8 years ago
These issues are candidates for version 1.3.0.

Original comment by richard.eckart on 7 May 2011 at 5:31

GoogleCodeExporter commented 8 years ago

Original comment by richard.eckart on 4 Jan 2012 at 10:51

GoogleCodeExporter commented 8 years ago

Original comment by richard.eckart on 5 Jul 2012 at 4:02

GoogleCodeExporter commented 8 years ago
Created new method "contains" and deprecated the old one.

Original comment by richard.eckart on 5 Jul 2012 at 9:41