search

kammerje / spaceKLIP

Pipeline for reducing JWST high-contrast imaging data. Published in Kammerer et al. 2022 and Carter et al. 2022.
https://ui.adsabs.harvard.edu/abs/2022SPIE12180E..3NK/abstract
MIT License
16 stars 9 forks source link

Should switch to enable MIRI dark sub in reductions #110

Open mperrin opened 10 months ago

mperrin commented 10 months ago

@aggle informs us that there are good MIRI coron darks in CRDS now, particularly after he found and fixed an error with the F1550 one yesterday.

I believe it is still the case that spaceKLIP is skipping the MIRI dark step because the early darks had insufficient SNR. Jonathan says this is no longer the case so we should enable that step in reductions.

aggle commented 10 months ago

Just to be clear, only the 1550 has a good dark right now. I’m trying to find out why there aren’t in-flight darks for the other subarrays, since the data have been taken.

Jonathan

Jonathan Aguilar, Ph.D. Sr. Staff Scientist, MIRI Branch Space Telescope Science Institute he/his

From: Marshall Perrin @.> Reply-To: kammerje/spaceKLIP @.> Date: Wednesday, October 18, 2023 at 10:47 To: kammerje/spaceKLIP @.> Cc: Jonathan Aguilar @.>, Mention @.***> Subject: [kammerje/spaceKLIP] Should switch to enable MIRI dark sub in reductions (Issue #110)

@agglehttps://urldefense.com/v3/__https:/github.com/aggle__;!!CrWY41Z8OgsX0i-WU-0LuAcUu2o!wGQdY6YtPYUo3s9IoEumGRS1k1D6jk3jVgRP-54s72ogye3eo3gGfQvsAHn0S-nUOfAM0d5LJAip8i6pkTWyuudnEw$ informs us that there are good MIRI coron darks in CRDS now, particularly after he found and fixed an error with the F1550 one yesterday.

I believe it is still the case that spaceKLIP is skipping the MIRI dark step because the early darks had insufficient SNR. Jonathan says this is no longer the case so we should enable that step in reductions.

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/kammerje/spaceKLIP/issues/110__;!!CrWY41Z8OgsX0i-WU-0LuAcUu2o!wGQdY6YtPYUo3s9IoEumGRS1k1D6jk3jVgRP-54s72ogye3eo3gGfQvsAHn0S-nUOfAM0d5LJAip8i6pkTVrAupFAw$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/ABRNSYW3XF66VTQZFEOIKDDX77TZVAVCNFSM6AAAAAA6FU74G2VHI2DSMVQWIX3LMV43ASLTON2WKOZRHE2DSOJUGE4TEOA__;!!CrWY41Z8OgsX0i-WU-0LuAcUu2o!wGQdY6YtPYUo3s9IoEumGRS1k1D6jk3jVgRP-54s72ogye3eo3gGfQvsAHn0S-nUOfAM0d5LJAip8i6pkTWJpscS4g$. You are receiving this because you were mentioned.Message ID: @.***>

aggle commented 10 months ago

Here is a link to the correct dark file for the 1550: https://jwst-crds.stsci.edu/browse/jwst_miri_dark_0098.fits

You can enable it in the pipeline by passing {"override_dark": "/path/to/jwst_miri_dark_0098.fits"} to the "dark_current" step in your step parameters.

kammerje commented 3 months ago

@aggle Are there good darks for all filters now?

AarynnCarter commented 3 weeks ago

Bumping this, any update @aggle?

aggle commented 3 weeks ago

Hi all, just seeing this now. We just got our first round of real darks, but they do not look good, so I would not enable dark subtraction yet.

Jonathan

Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Aarynn Carter @.> Sent: Tuesday, July 30, 2024 5:32:08 PM To: kammerje/spaceKLIP @.> Cc: Jonathan Aguilar @.>; Mention @.> Subject: Re: [kammerje/spaceKLIP] Should switch to enable MIRI dark sub in reductions (Issue #110)

Bumping this, any update @agglehttps://urldefense.com/v3/__https://github.com/aggle__;!!CrWY41Z8OgsX0i-WU-0LuAcUu2o!0f9wLiBK_Wp2wQ_sYqUwY282Cm-AZq_hrXaV8nzo4nPmbPB04UfGbex7LeShiyXoanP9QUziPGX8hsVuiX_8BeaCXw$?

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/kammerje/spaceKLIP/issues/110*issuecomment-2259248070__;Iw!!CrWY41Z8OgsX0i-WU-0LuAcUu2o!0f9wLiBK_Wp2wQ_sYqUwY282Cm-AZq_hrXaV8nzo4nPmbPB04UfGbex7LeShiyXoanP9QUziPGX8hsVuiX-AjnWVwQ$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ABRNSYWJVNKEFEXZIVFUBATZPAA5RAVCNFSM6AAAAAA6FU74G2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJZGI2DQMBXGA__;!!CrWY41Z8OgsX0i-WU-0LuAcUu2o!0f9wLiBK_Wp2wQ_sYqUwY282Cm-AZq_hrXaV8nzo4nPmbPB04UfGbex7LeShiyXoanP9QUziPGX8hsVuiX8HqKoKWw$. You are receiving this because you were mentioned.Message ID: @.***>

AarynnCarter commented 3 weeks ago

Okay sounds good, thanks!