Minor edits by Ell - Githubissues

kammerje / spaceKLIP

Pipeline for reducing JWST high-contrast imaging data. Published in Kammerer et al. 2022 and Carter et al. 2022.

https://ui.adsabs.harvard.edu/abs/2022SPIE12180E..3NK/abstract

MIT License

16 stars 9 forks source link

Minor edits by Ell #149

Closed ell-bogat closed 5 months ago

ell-bogat commented 6 months ago

Enabled stellar spectrum generation using the Phoenix catalogs (for M dwarfs) via a keyword argument to WebbPSF
Fixed a minor plotting error caused by having more than 13 images in the database
Enabled frame-dependent bad pixel masks (i.e. you can make a 3D bad pixel mask)

kammerje commented 5 months ago

Hi @ell-bogat, thanks a lot for creating this PR! I'm happy to merge this, but there is one thing that might need further attention. In the meantime, I have fixed the missing outer working angle directly in the pyKLIP class (see https://github.com/kammerje/spaceKLIP/blob/dev/jk/spaceKLIP/pyklippipeline.py#L257) which I think is the more elegant solution. It is currently only part of the dev/jk branch, but will hopefully be merged into the develop branch properly soon.

ell-bogat commented 5 months ago

Gotcha, I can just revert the last commit so only the bp map and stellar spectrum catalog changes are included!

juliengirard commented 5 months ago

awesome @ell-bogat I ran into that plotting error with too many images