search

kammerje / spaceKLIP

Pipeline for reducing JWST high-contrast imaging data. Published in Kammerer et al. 2022 and Carter et al. 2022.
https://ui.adsabs.harvard.edu/abs/2022SPIE12180E..3NK/abstract
MIT License
16 stars 11 forks source link

Update tutorial notebooks example code for fix_bad_pixels bpclean #161

Open mperrin opened 7 months ago

mperrin commented 7 months ago

@juliengirard says that in recent testing by him and @asahooexo, they are finding that for fix_bad_pixels it is too severe to set the threshold at 3 sigma ( bpclean_kwargs={'sigclip': 3,). In some cases this results in bright speckles in the PSF core being masked out as bad. Setting sigma to 5 or 7 seems better.

It would be nice to update the tutorial notebooks to have values which work pretty well in general, so this seems like a good simple change.

There may be other updates in bad pixel cleaning recommended settings as well. Pending future feedback from @juliengirard and @asahooexo.

AarynnCarter commented 7 months ago

Just a quick update that I am planning to take an in depth look at the pixel cleaning in May.

mperrin commented 3 months ago

Is this addressed as part of PR #194 by @AarynnCarter ?

AarynnCarter commented 3 months ago

@mperrin Tutorials haven't been updated, just the code. I won't have time to do that, so I think best to leave this until @kglidic finishes the tutorial adjustments.