search

kammerje / spaceKLIP

Pipeline for reducing JWST high-contrast imaging data. Published in Kammerer et al. 2022 and Carter et al. 2022.
https://ui.adsabs.harvard.edu/abs/2022SPIE12180E..3NK/abstract
MIT License
16 stars 9 forks source link

Formalising stsci.stimage requirement due to recent update issues #167

Closed AarynnCarter closed 2 months ago

AarynnCarter commented 2 months ago

Edit: Sorry, not sure where the description went.

stsci.stimage updated last week and the latest 0.2.7 version is causing our CI runs to crash due to failed import of a stsci.stimage function. I've looked at the update and don't see any major change or improvement that we should account for, so I think it makes sense to lock things at 0.2.6 until they push another update so that we can keep our updates moving.

It seems they are already aware of the issue and have a PR in progress: https://github.com/spacetelescope/stsci.stimage/pull/37

mperrin commented 2 months ago

I'm trying to remember the context on this one and which update or other PR this was discussed in... It looks straightforward enough but could you add please at least one sentence to the PR description reminding why this is needed?

Is it intentional that the requirement is exactly equal to that version, ==0.2.6, rather than equal to or later than, >=0.2.6?

AarynnCarter commented 2 months ago

@mperrin Sorry about that, description above.