search

kammerje / spaceKLIP

Pipeline for reducing JWST high-contrast imaging data. Published in Kammerer et al. 2022 and Carter et al. 2022.
https://ui.adsabs.harvard.edu/abs/2022SPIE12180E..3NK/abstract
MIT License
16 stars 9 forks source link

Determine crpix from saif toggle #182

Closed wbalmer closed 3 weeks ago

wbalmer commented 1 month ago

See discussion in #114 . For data affected by bad fits writing behavior, for instance, the NIRCam BAR/NARROW offset position, it might be necessary to toggle calling the CRPIX values from pysaif, as opposed to recording them from the headers. This affects the position of the mask and therefore the coronagraphic throughput. Default behavior is unchanged and the toggle is set to false. Added to the appropriate functions in database.py

Potential improvement could look to incorporate @JarronL 's webbpsf_ext.imreg_tools.get_coron_apname function in the default database building step, but this change is non-intrusive and sufficient for current reductions (unlike the original implementation in #114 ).

wbalmer commented 1 month ago

Hi Aarynn - yep! I have tested the toggle behaves well when set false by default, when set false explicitly, and when set true explicitly.