kammerje / spaceKLIP

Pipeline for reducing JWST high-contrast imaging data. Published in Kammerer et al. 2022 and Carter et al. 2022.
https://ui.adsabs.harvard.edu/abs/2022SPIE12180E..3NK/abstract
MIT License
16 stars 10 forks source link

Added updated NIRCam tutorial #212

Open kglidic opened 1 month ago

kglidic commented 1 month ago

I've added updated NIRCam reduction notebooks. This draft is intended for initial feedback and review.

AarynnCarter commented 3 days ago

Hi Kayli,

Awesome work, this is almost there! Having issues with PyCharm so have to put my comments here:

AarynnCarter commented 3 days ago

Ah and another one:

mperrin commented 1 day ago

The interactive plot display works, but I get a bunch of extra warning text from every display_coron_dataset call, and also for display_image_comparisons. This outputs over and over again for every time one of the sliders is clicked to adjust the displayed image number, which is super annoying. I don't understand what has turned on these py.warnings:WARNING messages, which I don't recall having seen before. Sigh.

[py.warnings:WARNING] /Users/mperrin/Dropbox (Personal)/Documents/software/git/spaceKLIP/spaceKLIP/plotting.py:280: RuntimeWarning: Mean of empty slice
[py.warnings:WARNING]   image = np.nanmean(model.data, axis=0) if cube_ints else model.data
[py.warnings:WARNING] 
[py.warnings:WARNING] /Users/mperrin/miniconda3/envs/stenv-py3.11-2024.02.05/lib/python3.11/site-packages/astropy/wcs/wcs.py:807: FITSFixedWarning: 'datfix' made the change 'Set DATE-BEG to '2022-07-30T05:06:00.117' from MJD-BEG.
[py.warnings:WARNING] Set DATE-AVG to '2022-07-30T05:11:09.069' from MJD-AVG.
[py.warnings:WARNING] Set DATE-END to '2022-07-30T05:16:18.022' from MJD-END'.
[py.warnings:WARNING]   warnings.warn(
[py.warnings:WARNING] 
[py.warnings:WARNING] /Users/mperrin/miniconda3/envs/stenv-py3.11-2024.02.05/lib/python3.11/site-packages/astropy/wcs/wcs.py:807: FITSFixedWarning: 'obsfix' made the change 'Set OBSGEO-L to   -67.360184 from OBSGEO-[XYZ].
[py.warnings:WARNING] Set OBSGEO-B to   -35.180767 from OBSGEO-[XYZ].
[py.warnings:WARNING] Set OBSGEO-H to 1706122045.054 from OBSGEO-[XYZ]'.
[py.warnings:WARNING]   warnings.warn(
[py.warnings:WARNING] 
[py.warnings:WARNING] /Users/mperrin/miniconda3/envs/stenv-py3.11-2024.02.05/lib/python3.11/site-packages/astropy/stats/sigma_clipping.py:438: AstropyUserWarning: Input data contains invalid values (NaNs or infs), which were automatically clipped.
[py.warnings:WARNING]   warnings.warn(
[py.warnings:WARNING] 
[py.warnings:WARNING] /Users/mperrin/Dropbox (Personal)/Documents/software/git/spaceKLIP/spaceKLIP/plotting.py:379: UserWarning: This figure includes Axes that are not compatible with tight_layout, so results might be incorrect.
[py.warnings:WARNING]   fig.tight_layout(rect=[0.3, 0, 1, 1])
[py.warnings:WARNING] 
[py.warnings:WARNING] /Users/mperrin/Dropbox (Personal)/Documents/software/git/spaceKLIP/spaceKLIP/plotting.py:380: UserWarning: FigureCanvasAgg is non-interactive, and thus cannot be shown
[py.warnings:WARNING]   fig.show()
[py.warnings:WARNING] 

Some relatively minor comments on the notebook text.