Fixes to ensure replicability of ERS MIRI Data

kammerje / spaceKLIP

Pipeline for reducing JWST high-contrast imaging data. Published in Kammerer et al. 2022 and Carter et al. 2022.

https://ui.adsabs.harvard.edu/abs/2022SPIE12180E..3NK/abstract

MIT License

16 stars 10 forks source link

Fixes to ensure replicability of ERS MIRI Data #90

Closed AarynnCarter closed 11 months ago

AarynnCarter commented 1 year ago

Adds some small fixes to enable replicability of ERS MIRI data. Specifically:

Added functionality for different nsplit between science and reference when performing background subtraction.
Corrected indexing of centers for input into pyklip

pyklip uses an arange(N) command to build the x, y coordinate map for alignment, which is 0-indexed. Therefore, centers must be provided as if they were 0-indexed. That is, (np.array(data.shape[1:])-1)/ 2. instead of np.array(data.shape[1:])/ 2..

AarynnCarter commented 1 year ago

Okay @mperrin, this should now be updated following our discussion above. I didn't implement a restrict_to command as I thought it would be best to do that within your branch.

mperrin commented 1 year ago

@AarynnCarter since this is ready for review, can you please move it from Draft PR status to Ready for Review? Thanks