search

kamon-io / Kamon

Distributed Tracing, Metrics and Context Propagation for applications running on the JVM
https://kamon.io
Other
1.41k stars 328 forks source link

Support client-side Akka gRPC requests #1120

Open ivantopo opened 2 years ago

ivantopo commented 2 years ago

While working on the service side support (#1119) I noticed it shouldn't be extremely hard to create client Spans for Akka gRPC calls. Also worth taking a look at @jtjeferreira's work here: https://github.com/nezasa/kamon-akka-grpc/

insdami commented 2 years ago

Hey @ivantopo, we ended up using @jtjeferreira with a bit of hesitation due to not being part of the kamon akka grpc module and some outdated dependencies.

Is there any reason why https://github.com/nezasa/kamon-akka-grpc/ is not part of the Kamon official instrumentation? Is there something I can do to contribute to that if it's something suited for new people to Kamon?

ivantopo commented 2 years ago

Hey @insdami, its just lack of time I guess! There was an open PR here: https://github.com/kamon-io/Kamon/pull/1153 but I'm not sure why it got closed. I do remember that there were some challenges around doing context propagation properly.

Are you interested in working on that PR (adapting @jtjeferreira's work with the latest Kamon and opening a PR)?

jtjeferreira commented 2 years ago

btw I released a new version of kamon-akka-grpc https://github.com/nezasa/kamon-akka-grpc/releases/tag/v0.2.0