kamon-io / Kamon

Distributed Tracing, Metrics and Context Propagation for applications running on the JVM
https://kamon.io
Other
1.41k stars 329 forks source link

Losing context when using cats parallel #1238

Open igullickson opened 1 year ago

igullickson commented 1 year ago

Hello, we observed an issue where context is lost after a call to a cats parallel method is made, such as parSequence.

Here is an example test that demonstrates the issue: https://gist.github.com/igullickson/2c45e5922c464d196f6b4a2aa10c500a

We are using:

We are using the following configuration for kamon/cats effect:

kanela.modules {
  executor-service-capture-on-submit.enabled = true

  executor-service {
    within += "cats.effect.internals.Callback\\$AsyncIdempotentCallback"
  }
}

Trying other configuration variations such as the example here did not fix the context propagation.

Any help or feedback otherwise is much appreciated.

ivantopo commented 1 year ago

Hey @igullickson, thanks for reporting this and more importantly, for the reproducible! I'm not sure how easy it would be to get this fixed, but I'll take a look at it asap. Adding this to my work queue.

cavanhussein commented 2 months ago

Hi @ivantopo, thank you for taking a look into this!! Just checking in to see if there any update on this. I am on @igullickson previous team. Hi Isaac!! Hope all is well :)

Thanks a bunch, Cavan