search

kamon-io / Kamon

Distributed Tracing, Metrics and Context Propagation for applications running on the JVM
https://kamon.io
Other
1.41k stars 328 forks source link

Allow configuration of the percentile metrics to submit in Datadog API reporter #1360

Closed thyandrecardoso closed 1 month ago

thyandrecardoso commented 2 months ago

Currently, only p95 gets reported. Looking at p99 seems a fairly common and important use case. I tested this by making sure that these changes work against our Datadog account and I see the new metric.

Can we report p99 as well?

ivantopo commented 2 months ago

I think that adding the p99 would be a good addition, but I wouldn't just add it as a default because that one additional metric could have a significant effect on people's bills because they are counted as custom metrics.

Could you please change the implementation so that we read a list of percentiles from config (similar to how the influxdb reporter does here: https://github.com/kamon-io/Kamon/blob/master/reporters/kamon-influxdb/src/main/resources/reference.conf#L16) and default to only the p95 so that it behaves the same after people upgrade?

thyandrecardoso commented 2 months ago

Makes sense. Will try to improve this in the upcoming days...

thyandrecardoso commented 2 months ago

@ivantopo Hi, can you take a look at this again please?