search

kamon-io / Kamon

Distributed Tracing, Metrics and Context Propagation for applications running on the JVM
https://kamon.io
Other
1.41k stars 328 forks source link

make kamon-pekko tolerant of null dispatcherPrerequisites #1361

Closed pjfanning closed 2 months ago

pjfanning commented 2 months ago

relates to #1352

unit tests pass and tested with https://github.com/pjfanning/kamon-pekko-http-test

The NPE may pop up in other use cases but this sorts the one seen in #1352

I know a fuller fix is needed - one that ensures the dispatcherPrerequisites are found but that can be done independently.

hughsimpson commented 2 months ago

I've been spending some time today trying to figure out what's causing this (cf https://github.com/kamon-io/Kamon/pull/1362) and honestly I'm not sure, but it seems like various pieces of instrumentation aren't working... Especially in scala 2.13. Scala 3 doesn't seem to have any issues.. so that's odd. Would rather the instrumentation tests passed for pekko 1.1, because otherwise we're probably hiding errors...

pjfanning commented 2 months ago

@hughsimpson feel free to do a new PR that sorts out the instrumentation issue. This PR is useful as far as I am concerned because it stops Kamon from crashing the JVM.

To repeat what I said in the PR description: I know a fuller fix is needed - one that ensures the dispatcherPrerequisites are found but that can be done independently.