search

kamon-io / Kamon

Distributed Tracing, Metrics and Context Propagation for applications running on the JVM
https://kamon.io
Other
1.41k stars 328 forks source link

add kamon-pekko-connectors-kafka #1367

Closed pjfanning closed 1 month ago

pjfanning commented 1 month ago

based on alpakka-kafka

pjfanning commented 1 month ago

CI test failures were in kamon-http4s

hughsimpson commented 1 month ago

Would you mind adding a test?

pjfanning commented 1 month ago

This is 100% a copy of the alpakka-kafka code and it has no tests. I have limited time to spend on Kamon stuff.

hughsimpson commented 1 month ago

I'm not even sure this really does much useful, since a context will live directly on the producer record on creation, and that's what's used for propagation (assuming the kamon-kafka instrumentation is switched on). I tried to write a test for this, but couldn't make one that failed without the code. I suppose this should at least fix any mdc fields on logs emitted during a commit, though. Life's too short. Merging.