kamon-io / Kamon

Distributed Tracing, Metrics and Context Propagation for applications running on the JVM
https://kamon.io
Other
1.41k stars 328 forks source link

NoSuchMethodError ActorSystem.shutdown() #459

Closed swachter closed 7 years ago

swachter commented 7 years ago

Kamon.shutdown() uses the deprecated method ActorSystem.shutdown() that is no more available in Akka 2.5.

rrodseth commented 7 years ago

I'm also hoping to start using Akka 2.5.1, but am dependent on Kamon.

dpsoft commented 7 years ago

Guys we just published a snapshot versión of kamon-core:[ 0.6.7-469c11dc1ddb140f407a33f48033e533bf60611c] that supports akka 2.5.x.

rrodseth commented 7 years ago

Thanks.

UriShohet commented 7 years ago

@dpsoft the code for scala 2.11 version still says system.shutdown()...

jan-pieter commented 7 years ago

The called method should not be dependent on the scala version but on the akka version used. The minimum akka version is dependent on the scala version but a newer version might be used.

jan-pieter commented 7 years ago

PR: https://github.com/kamon-io/Kamon/pull/460

rrodseth commented 7 years ago

Thanks for the 0.6.7 release. I'll try it out as soon as it shows up in Maven Central.

dpsoft commented 7 years ago

@rrodseth there is: http://search.maven.org/#artifactdetails%7Cio.kamon%7Ckamon-core_2.12%7C0.6.7%7C

rrodseth commented 7 years ago

Thanks. I'm on 2.11 but I can/should probably update this particular app.

rrodseth commented 7 years ago

Oh, I see core is there, but The following artifacts could not be resolved: io.kamon:kamon-log-reporter_2.11:jar:0.6.7, io.kamon:kamon-system-metrics_2.11:jar:0.6.7, io.kamon:kamon-statsd_2.11:jar:0.6.7, io.kamon:kamon-datadog_2.11:jar:0.6.7: Failure to find io.kamon:kamon-log-reporter_2.11:jar:0.6.7

dpsoft commented 7 years ago

Please only change kamon-core.

rrodseth commented 7 years ago

So far so good. Was able to update core only and do

       CoordinatedShutdown(system).addTask(CoordinatedShutdown.PhaseActorSystemTerminate, "shutdownKamon") { () =>
        println(s"Shutting down Kamon with coordinated shutdown")
        Kamon.shutdown()
        Future.successful(Done)
      }