search

kamon-io / Kamon

Distributed Tracing, Metrics and Context Propagation for applications running on the JVM
https://kamon.io
Other
1.41k stars 327 forks source link

Should we have a global tags configuration for reporters? #529

Open ivantopo opened 6 years ago

ivantopo commented 6 years ago

@Falmarri raised a very good point here:

image

It certainly makes sense to have global defaults and allow each module to change their settings. There is one small shift on the way we think about reporting modules, specially related to what is being discussed in #524: we should be thinking of Reporter instances, assuming that it is possible for people to configure more than one instance of a given reporter. This is not something that people need to do very often, but its something that came up several times and I see how the improvements in reporters' configuration can make that come naturally.

There is one more thing to take into account: the Datadog, StatsD, InfluxDB and Sematext SPM modules are just about to be released and I would definitely prefer to release them first and then get into these improvements.

Looking forward to comments!

ivantopo commented 4 years ago

I'm closing this issue because it is either too old to be relevant or stale. Stop by our Github Discussions section and drop a message if you need any additional help with the topic.

Have a nice day!