search

kamon-io / Kamon

Distributed Tracing, Metrics and Context Propagation for applications running on the JVM
https://kamon.io
Other
1.41k stars 327 forks source link

Akka htttp 1.12.0 - new server start #831

Open fggarcia opened 4 years ago

fggarcia commented 4 years ago

Akka-http 1.12.0 introduce a new interface to start a server.

 http.newServerAt(serverConfig.getString("interface"), serverConfig.getInt("port")).bind(routes)

Searching in kamon.instrumentation:

https://github.com/kamon-io/Kamon/blob/05613bfc533c9bc81737cb3c7df9bc3d00799873/instrumentation/kamon-akka-http/src/main/scala-2.13/kamon/instrumentation/akka/http/AkkaHttpServerInstrumentation.scala#L43

method bindAndHandle will be deprecated.

So maybe there must be an option to the new method

tPl0ch commented 4 years ago

After the update to 1.12.0 our APM per route is broken. Can I somehow support on this?

SimunKaracic commented 3 years ago

What version of akka-http is this broken? I can't find a version 1.12.0 Can you elaborate what failures you have?