akka.router.pending-messages as a range sampler tracking how many messages are waiting to be processed across all routees of a router.
akka.router.members as a range sampler tracking the number of routees in a router.
The akka.group.mailbox-size metric was renamed to akka.group.pending-messages to stay consistent with the previous change (pending messages is much more close to reality than mailbox size since there is no single mailbox there).
All routers now have a routerClass and routeeClass tags.
The dispatcher tag used on BalancingPool routers have been fixed. For this type of routers the routees would always get a special dispatcher assigned, but the router itself could run on a different dispatcher (usually the default dispatcher). This duplicates the number of metrics created for BalancingDispatchers and leaves half of them alive when removing the router. Since this PR the router actor will have the disparcher tag value to match the dispatcher name of the routees, which is not accurate, but we can live with that.
These changes are only applied for Akka 2.5 for review, if all looks good I'll migrate them to Akka 2.4 as well.
dpsoft
commented
6 years ago
The PR includes a few changes:
akka.router.pending-messagesas a range sampler tracking how many messages are waiting to be processed across all routees of a router.akka.router.membersas a range sampler tracking the number of routees in a router.akka.group.mailbox-sizemetric was renamed toakka.group.pending-messagesto stay consistent with the previous change (pending messages is much more close to reality than mailbox size since there is no single mailbox there).routerClassandrouteeClasstags.dispatchertag used on BalancingPool routers have been fixed. For this type of routers the routees would always get a special dispatcher assigned, but the router itself could run on a different dispatcher (usually the default dispatcher). This duplicates the number of metrics created for BalancingDispatchers and leaves half of them alive when removing the router. Since this PR the router actor will have the disparcher tag value to match the dispatcher name of the routees, which is not accurate, but we can live with that.These changes are only applied for Akka 2.5 for review, if all looks good I'll migrate them to Akka 2.4 as well.