search

kamon-io / kamon-http4s

Kamon Integration for http4s
Apache License 2.0
53 stars 29 forks source link

Update kamon-core #54

Open matwojcik opened 1 year ago

matwojcik commented 1 year ago

This project still depends on kamon-core 2.2.x. Can this be updated?

And in general @ivantopo - why is this not in kamon core repository like the rest of instrumentation? Should we consider this module as not maintained anymore?

ivantopo commented 1 year ago

hey @matwojcik 👋

There is this PR that should get looked into https://github.com/kamon-io/kamon-http4s/pull/50 and will probably be fine to go all the way up to Kamon 2.6.x

If my memory doesn't fail me, there was a time when the http4s versions and compatibility would mean a ton of build-related work on Kamon's main repo so we ended up not moving this instrumentation there until things got stable, but I'm guessing the time has come since quite some time ago. Ultimately, it all boils down to me not having as much time for Kamon as I used to have 😞

If anyone is willing to look at the PRs and ensure things are working properly I'm happy to merge things and publish, and of course provide guidance on the Kamon-related stuff. I have never used http4s myself and moving this instrumentation forward for me means to first understand http4s, then understand the internals, and then see it all come together. Its a bit hard for me at the moment.

matwojcik commented 1 year ago

Hi @ivantopo, thanks for the answer. I may not be competent enough to review the PR properly, but what I can offer is to verify this working in our apps if there is some SNAPSHOT/RC version published so I can download it. 2.5.x version is even better for us trialing, because our apps so far depend on kamon 2.5.x ;)