propagate to MDC even if no Span is present, handle key key types gracefully

kamon-io / kamon-logback

12 stars 17 forks source link

Closed ivantopo closed 5 years ago

ivantopo commented 5 years ago

These changes are based on the suggestion here: https://gitter.im/kamon-io/Kamon?at=5c34a77dbd592b2e6e6fbd46. The core of it is:

Ensure that context keys can be added to the MDC regardless of whether there is a Span in the context or not.
Allow any key to be put into the MDC, not only Option[String] as it is now.

dpsoft commented 5 years ago

@ivantopo @chotai LGTM!