search

kamon-io / kamon-logback

12 stars 17 forks source link

Allow any type of broadcast key to be put into the MDC #17

Closed chotai closed 5 years ago

chotai commented 5 years ago

This change is in connection to https://gitter.im/kamon-io/Kamon?at=5c34a77dbd592b2e6e6fbd46 and kamon-io#14

Currently when MDC propagation is on, if a service is configured to use a Broadcast key other then Option[String], we lose logging.

Allow any broadcast key to be put into the MDC, not only Option[String] as it is now.

dpsoft commented 5 years ago

@chotai LGTM @ivantopo?

ivantopo commented 5 years ago

@chotai thanks a lot for this PR and sorry for taking so long :'(... I just released it as 1.0.7!