search

kamon-io / kamon-logback

12 stars 17 forks source link

Remove AsyncAppender instrumentation #22

Closed jalaziz closed 5 years ago

jalaziz commented 5 years ago

Instrumenting AysncAppender is not needed since the event already captures the correct Context when it is created.

Fixes #8

jalaziz commented 5 years ago

Fun fact @ivantopo if you look at the Gitter link in #8, you had the same conclusion back in 2018 😂

ivantopo commented 5 years ago

Fun fact @ivantopo if you look at the Gitter link in #8, you had the same conclusion back in 2018

Oh man, yet another reason to approve this PR!