search

kamon-io / kamon-logback

12 stars 17 forks source link

Restore the complete MDC after propagation #25

Closed carstenlenz closed 5 years ago

carstenlenz commented 5 years ago

This saves the MDC before propagation and restores it afterwards. I don't know if there are issues with this approach. Let me know what you think.

Would fix #23

carstenlenz commented 5 years ago

Travis failed with the interesting message 

Expected feature release number in range of 9 to 14, but got: 8

The command "~/bin/install-jdk.sh --target "/home/travis/oraclejdk8" --workspace "/home/travis/.cache/install-jdk" --feature "8" --license "BCL"" failed and exited with 3 during .
ihostage commented 5 years ago

@carstenlenz Time to use Jabba and AdoptOpenJDK 😄 

before_install: curl -Ls https://git.io/jabba | bash && . ~/.jabba/jabba.sh
install: jabba install "$TRAVIS_JDK" && jabba use $_ && java -Xmx32m -version

env:
  matrix:
    - TRAVIS_JDK=adopt@1.8.202-08

instead of

jdk:
   - oraclejdk8
carstenlenz commented 5 years ago

Thanks @ihostage ! Directly worked :)