search

kamon-io / kamon.io

Sources for the https://kamon.io/ website.
9 stars 57 forks source link

Instructions for Play production mode only didn't work for me #117

Open ctoomey opened 3 years ago

ctoomey commented 3 years ago

When following the instructions, after sbt disting and then running Play (in production mode), there were no metrics reported via the Prometheus exporter web page.

Actually there were a few kamon metrics, but not the hundreds of akka metrics I got otherwise when using the SBT Kanela Runner Plugin, in both dev and production mode.

I noticed in the dist-generated start script, there was no -javaagent: JVM argument provided, which I'm guessing is the problem since I understand you're using the aspectj agent to do the instrumentation. Seems the instructions are thus missing the needed step of adding this to build.sbt: javaAgents += "org.aspectj" % "aspectjweaver" % "1.9.6" % "runtime".

ctoomey commented 3 years ago

Update: adding this to build.sbt: javaAgents += "org.aspectj" % "aspectjweaver" % "1.9.6" % "runtime" didn't get it to work in production mode either.

Please let me know how to enable production mode only.

ivantopo commented 3 years ago

Hey @ctoomey, thanks for bringing this up. I'll update that guide ASAP!

We are not using AspectJ since Kamon 2.x. The new agent is our own Kanela agent :smile:. The right dependency to add would be javaAgents += "io.kamon" % "kanela-agent" % "1.0.11". More info here.

Please let me know if that fixes it for you. Thanks!