kamon-io / kanela

The Kamon Instrumentation Agent
Apache License 2.0
68 stars 22 forks source link

kamon can not work with datadog agent #137

Open uname-yang opened 2 years ago

uname-yang commented 2 years ago

Hi we use kamon and datadog together. but it conflict with datadog agent from version 0.55. is there any way to solve this ?

image

thanks

dpsoft commented 2 years ago

Hi @uname-yang, are you using the kamon bundle? can you try adding the kanela agent jar to the jvm params like -J-javaagent:dd-java-agent.jar -J-javaagent:kanela-agent.jar?

uname-yang commented 2 years ago

image

still not work by using jvm opts

dpsoft commented 2 years ago

@uname-yang only for double check:

Also you can add kanela.debug-mode = true in your application.config in order to get more information over the instrumentation process.

@ivantopo any thoughts?

uname-yang commented 2 years ago

@dpsoft thanks for checking:

  1. we can run only with kanela. It works.
  2. it's no different when exchange the order.

attach the log here

log.txt

I guess there must be some common lib using by dd and kamon , such as bytebuddy, only can be applied once.

dpsoft commented 2 years ago

@uname-yang can you try disabling okhttp instrumentation -> kanela.modules.okhttp-module.enabled=false? I think kanela is trying to instrument the okhttp client inside of dd-agent. An in a second try you can comment //Kamon.init() and pass the agent as JVM argument.

Thanks in advance.

uname-yang commented 2 years ago

@dpsoft i check the source code. It seems okhhttp-module does not have enabled flag. Here is the error log when start app as your suggestion, same as before: image

dpsoft commented 2 years ago

@uname-yang all kanela modules inherit the module configuration with some default values described in kanela [configuration]. Can you try adding


kanela {
   debug-mode = true
   log-level = "DEBUG"
   modules.okhttp-module.enabled = false
}

and share the log with us?

[configuration]: https://github.com/kamon-io/kanela/blob/master/agent/src/main/resources/reference.conf#L23
uname-yang commented 2 years ago

log.txt

Please help and advise. Thanks

uname-yang commented 2 years ago

@uname-yang all kanela modules inherit the module configuration with some default values described in kanela [configuration]. Can you try adding

kanela {
   debug-mode = true
   log-level = "DEBUG"
   modules.okhttp-module.enabled = false
}

and share the log with us?

[configuration]: https://github.com/kamon-io/kanela/blob/master/agent/src/main/resources/reference.conf#L23

any updates?

stewart-shawn commented 2 years ago

Is there any update on this? We have the same issue.

dpsoft commented 2 years ago

Hi @uname-yang @stewart-shawn, any chance to make a minimal executable example to play with and try to reproduce the problem?

stewart-shawn commented 2 years ago

@dpsoft No problem. I've added an example here: https://github.com/stewart-shawn/dd-kamon-demo. Thanks for checking into this

dpsoft commented 2 years ago

@stewart-shawn awesome, I will take a look ASAP

nmadhavi33 commented 2 years ago

@dpsoft any update on this issue? we have the same issue

anujprashar commented 2 years ago

@dpsoft @ivantopo Is this fixed or when can we expect this to be fixed. we are blocked due to this.

uname-yang commented 2 years ago

@stewart-shawn awesome, I will take a look ASAP

any updates here?

siddshuk commented 2 years ago

@dpsoft - Currently blocked due to this as well. Did you get a chance to take a look?