Zuhaib042
commented
1 year ago Hi @kamranahmad123
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
✅ Implemented most of the requirements
Required Changes ♻️
- [ ] Good job but I cant see the cards assigned to anyone. Kindly consider assigning all the cards to their respective assignee. the cards should get assigned equally. kindly apply the following requirement:
- Each of the team members should assign themselves to the cards from all categories (and time estimate distributions should be fair - no single person should be doing all of the most time-consuming tasks). Decide who will be the assignee for the cards marked as group tasks (it can be one person or all team members). All cards on your Kanban board should have assignees.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
gemmen29
1- Steup Kanban-board project for two people
https://github.com/kamranahmad123/Space-Travelers-Hub/projects/2