search

kamranahmedse / developer-roadmap

Interactive roadmaps, guides and other educational content to help developers grow in their careers.
https://roadmap.sh
Other
298.17k stars 39.22k forks source link

Typo in React roadmap #7688

Closed Ankrat closed 2 weeks ago

Ankrat commented 2 weeks ago

Detailed Description

roadmap/react

Personal recommendation tick is blue. But the pick one state purple:

Screenshot 2024-11-06 at 10 18 48

fellalli commented 2 weeks ago

Let’s update the color from blue to purple to keep it consistent with the other roadmaps.

brendancjz commented 2 weeks ago

Hi @fellalli, I would like to help with this issue. As this is my first task, I need the correct access rights. Running npm run generate-renderer fails. Any advice on how to move forward?

fellalli commented 2 weeks ago

Hi @fellalli, I would like to help with this issue. As this is my first task, I need the correct access rights. Running npm run generate-renderer fails. Any advice on how to move forward?

Hi @brendancjz, it's a private repository, and you don't need access to it in order to make contributions.

brendancjz commented 2 weeks ago

Noted! May I ask what's the hexcode for the purple color? :)

fellalli commented 2 weeks ago

The color is #874efe. However, I assume that JSON files where colors like this are stored are auto-generated and will likely be overwritten during the build process.

@arikchakma, could you please confirm if that’s correct?

brendancjz commented 2 weeks ago

Hi @fellalli, roger that. I have made the simple fix and created a PR here. Let me know if there's any updates needed. Thanks.

kamranahmedse commented 2 weeks ago

Looks good, thanks @fellalli @brendancjz