search

kamranahmedse / git-standup

Recall what you did on the last working day. Psst! or be nosy and find what someone else in your team did ;-)
MIT License
7.59k stars 303 forks source link

$WEEKSTART comparison fails on non-English locales. #83

Open AndySun25 opened 6 years ago

AndySun25 commented 6 years ago

We have had a few devs at our group being unable to use git-standup on Mondays due to the hardcoded comparison for $WEEKSTART. I've forked the repo and made a quick fix for internal use and was wondering if there may be interest in implementing it upstream as well.

gimi-org/git-standup@c74aa71fa1d2f4f221c31b5544e4e52cfd976628

I'm fairly new to writing bash scripts with cross-platform compatibility so any sort of feedback would be appreciated. (And yes there is a typo in that commit but that has since been fixed)

devoth commented 4 years ago

This still seems to be an issue for me, every monday I need to remember to run git standup -d3 instead of git standup otherwise it tells me I did nothing last day ;)