search

kamranahmedse / githunt

Hunt the most starred projects on any date on GitHub
https://kamranahmed.info/githunt
MIT License
2.89k stars 268 forks source link

Fix text overflow issue with ellipsis #30

Closed melanieseltzer closed 4 years ago

melanieseltzer commented 5 years ago

Related Issue

Fixes #28

Since there's an explicit height on the tiles, an ellipsis can be used to clip the overflowing text.

Before

screen shot 2019-02-11 at 8 48 10 pm

After

screen shot 2019-02-11 at 8 48 03 pm

Before

screen shot 2019-02-11 at 8 48 45 pm

After

screen shot 2019-02-11 at 8 48 53 pm
Harzu commented 5 years ago

maybe try to make a line break?

melanieseltzer commented 5 years ago

It's been a while since I looked at this PR, but pretty sure I used an ellipsis because grid-item-body has an explicit height. If we don't clip it then it'll push long content out of the card.

@kamranahmedse Any input here?

kamranahmedse commented 4 years ago

Thanks @melanieseltzer 🙏