search

kamranahmedse / jquery-toast-plugin

Highly customizable jquery plugin to show toast messages
http://kamranahmed.info/toast
1.51k stars 507 forks source link

Please release as NPM package #9

Closed szyablitsky closed 8 years ago

szyablitsky commented 8 years ago

Thank you )

kamranahmedse commented 8 years ago

Will do. Thanks

istrau3 commented 8 years ago

I would also like to get this from npm. If not uploading to npm (or at least for the meantime), it would be great if you could just add a package.json (as npm can get directly from github). Currently when I try:

npm install kamranahmedse/jquery-toast-plugin --save

I get thrown an error that is related to the absence of package.json.

Really like the plugin...

kamranahmedse commented 8 years ago

Totally forgot about the issue. Expect it today.

kamranahmedse commented 8 years ago

Just released it, try: npm install jquery-toast-plugin

istrau3 commented 8 years ago

@kamranahmedse I just tried it. I am getting a webpack build error now that is related to the "main" entry in package.json. Any way you can change the following in package.json:

"main": "jquery.toast.js"

to read either:

"main": "dist/jquery.toast.min.js"

or

"main": "src/jquery.toast.js"

basically, to point to an existing file (something in webpack, not sure if it is webpack itself or one of the loaders, scans all the node_modules and indexes their main files and it is erroring out because jquery.toast.js does not exist in the root of jquery-toast-plugin).

kamranahmedse commented 8 years ago

Hey @istrau3 thank your for reporting that. Could you please try again? I just fixed that.

istrau3 commented 8 years ago

@kamranahmedse Looks to be working well now. Thanks a lot.