search

kamranahmedse / redux-persist-expire

Expiring transformer for redux-persist
MIT License
78 stars 12 forks source link

Reduce the lib size #2

Closed jeco123 closed 5 years ago

jeco123 commented 5 years ago

Hi, Thanks for your work :-). I suggest to reduce the lib size due to the use of the 'moment' lib. Please, date-fns could be interesting in your case.

have a nice day :-)

Jérôme

pungggi commented 5 years ago

yes, same advice grafik

sandinosaso commented 5 years ago

I created a PR to remove moment dependency https://github.com/kamranahmedse/redux-persist-expire/pull/8

sandinosaso commented 5 years ago

I think @pungggi you will be happy :)

Screen Shot 2019-05-21 at 1 48 38 PM
jeco123 commented 5 years ago

Waou good job @sandinosaso!

sandinosaso commented 5 years ago

Thanks, @jeco123 It was not that much hard is just on file with 2 big functions that need to be changed very little. I hope @kamranahmedse agree to merge this but in the meanwhile, if you need the change you can install from a branch using: yarn add https://github.com/sandinosaso/redux-persist-expire.git#feature/RemoveMoment When the branch is merged you need to change your package.json to point again to the library from npm. Could be useful for trying in the meanwhile

kamranahmedse commented 5 years ago

This has been released in 1.1.0. Thanks @sandinosaso.