search

kamranayub / cypress-browser-permissions

A Cypress plugin to set launched browser preferences including permissions like Geolocation, Notifications, Microphone, etc.
https://kamranicus.com/cypress-browser-permissions
MIT License
64 stars 4 forks source link

chore(package): remove extra `dist` when publishing #11

Closed kamranayub closed 4 years ago

kamranayub commented 4 years ago

prepare runs on install and publish, I think using prepublishOnly will fix this

kamranayub commented 4 years ago

This is half-fixed, on the publish side it is no longer packed with an extra dist folder but then when the consumer installs it, it gets put there 😬

See https://github.com/kamranayub/cypress-browser-permissions/issues/15#issuecomment-660248666

I think just doing a CI-only script may be the quickest solution, even though that makes local publishing annoying. It would just be ideal for the semantic-release plugin to respect publishConfig.directory like lerna does.

kamranayub commented 4 years ago

Fixed in https://github.com/kamranayub/cypress-browser-permissions/commit/9f99d4ba0adf2ecd3e504c8b7dc056fbb2c6e1a1