search

kamsar / Dianoga

An automatic image optimizer for the Sitecore media library.
Other
102 stars 45 forks source link

Avif support refactoring and JPEG XL support #100

Closed Antonytm closed 2 years ago

Antonytm commented 2 years ago
  1. Make next-gen image formats handling more generic. For adding a new format it should be enough to write one optimizer, write tests and add a configuration file.
  2. Refactoring Avif support implementation. (e.g. added Copywrite, fixed MediaRequestHandler.cs, etc.)
  3. Added JPEG XL optimizer
  4. Changed way of CDN configuration works. Here is the trade-off: see GenerateCacheKey.cs. That pipeline will be called even if CDN is not enabled, but execution will be skipped if CDN is not enabled. It is done to make configuration less complex.
  5. Updated readme.md
Antonytm commented 2 years ago

Hi @markgibbons25,

This PR contains a lot of changes making adoption of the new next-gen formats easier. I will make additional testing for different configurations to make sure that all scenarios work.

But meanwhile, can you please take a look at a whole approach in general and let me know your thoughts?

markgibbons25 commented 2 years ago

Looks perfect thanks! I can't see any issues :) Will release as v6 alpha.

Antonytm commented 2 years ago

I see that Antonytm:feature/avif based on kamsar:feature/avif in behind of kamsar:master. I will merge them, and fix conflicts.

markgibbons25 commented 2 years ago

Ah I didn't see this till now but I have resolved it, but let me know if I missed anything.

On Mon, 10 Jan 2022, 3:42 pm Antonytm, @.***> wrote:

I see that Antonytm:feature/avif based on kamsar:feature/avif in behind of kamsar:master. I will merge them, and fix conflicts.

— Reply to this email directly, view it on GitHub https://github.com/kamsar/Dianoga/pull/100#issuecomment-1008558738, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAYQJ5VWZIVUYDIXWJOXJCLUVJWSTANCNFSM5LRWTB5A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you modified the open/close state.Message ID: @.***>