kamsar / Dianoga

An automatic image optimizer for the Sitecore media library.
Other
102 stars 45 forks source link

Different assembly between NuGet and GitHub #108

Closed orna91 closed 2 years ago

orna91 commented 2 years ago

Adding Dianoga to my project via NuGet, I get the following error when starting Sitecore: "Message: Could not resolve type name: Dianoga.NextGenFormats.WebP.WebPThumbnailGenerator, Dianoga (method: Sitecore.Configuration.DefaultFactory.CreateFromTypeName (XmlNode configNode, String [] parameters, Boolean assert)). " Decompiling the Dianoga.dll obtained from NuGet I noticed that there is no NextGenFormats namespace. By downloading the project from GitHub the namespace is present.

I attach the screenshot of the decompiled Dianoga.dll. Can you verify that dll has been loaded on NuGet?

Thank you

Version of Dianoga

5.4.1.0

Dianoga-NuGet-Decompile-dll Dianoga-NuGet

markgibbons25 commented 2 years ago

Dianoga.NextGenFormats only is in the 6.x release, if you're looking at the readme on master branch then its actually for the 6.x, you can switch to the tag for the release you are on to get the right readme. That said, I'd encourage you to try 6.x, I don't forsee any more changes going into that release. https://www.nuget.org/packages/Dianoga/6.0.0-beta.3