search

kamsar / Dianoga

An automatic image optimizer for the Sitecore media library.
Other
104 stars 45 forks source link

Incorrectly serving webp when handling multiple requests at same time #51

Closed jeroendegroot closed 4 years ago

jeroendegroot commented 5 years ago

We are getting webp image served in IE when the same image is also served at the same time to a browser which does support webp. I have uploaded a video of this behavior here Here some additional information:

kamsar commented 5 years ago

WebP support has some known issues. I would recommend turning it off until those are fixed.

From: jeroendegroot notifications@github.com Sent: Tuesday, February 26, 2019 1:23:07 AM To: kamsar/Dianoga Cc: Subscribed Subject: [kamsar/Dianoga] Incorrectly serving webp when handling multiple requests at same time (#51)

We are getting webp image served in IE when the same image is also served at the same time to a browser which does support webp. I have uploaded a video of this behavior herehttps://jeroencdn.blob.core.windows.net/cdn/Dianoga_incorrectly_serving_webp.mp4 Here some additional information:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/kamsar/Dianoga/issues/51, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAGU_fk9TJc9hNxpXVKUSEQmtGMvAV1Pks5vRH5rgaJpZM4bRE7g.

jeroendegroot commented 5 years ago

Update in case this is helpful for someone else. This issue does not occur with the mediacache disabled. WebP provides some big performance improvements in our site. Since a CDN is being used I decided to turn off the media cache. Not the best solution but it ensures we can use WebP.

alex-nanai commented 5 years ago

This one fixed for me by applying protectedMediaQueryParameters as described in: https://github.com/kamsar/Dianoga/issues/49#issuecomment-506669654

markgibbons25 commented 4 years ago

This is now resolved https://github.com/kamsar/Dianoga/releases/tag/5.0.0-beta.1