search

kamsar / Dianoga

An automatic image optimizer for the Sitecore media library.
Other
102 stars 45 forks source link

AVIF support #89

Closed markgibbons25 closed 2 years ago

markgibbons25 commented 3 years ago

Who wants it? WIP branch: https://github.com/kamsar/Dianoga/tree/feature/avif PR: #90 Seeing some good gains over webp.

References: https://github.com/AOMediaCodec/libavif https://caniuse.com/avif

SudhirKumar2254 commented 3 years ago

@markgibbons25 - Do you need help on this issue ? If yes, could you please provide me more details . I am happy to help . :)

markgibbons25 commented 3 years ago

I am thinking that we won't support AVIF as it seems that JPEG XL is going to be much better and more widely adopted https://caniuse.com/jpegxl . So for now I will leave this here incase of any other discussion but when JPEG XL is supported in Chrome we can add that.

@SudhirKumar2254 if you do want to help you could suggest some refactoring of how we can better support these plugins.

SudhirKumar2254 commented 3 years ago

@markgibbons25 - Let's discuss and clear on what is expected here from me. Thanks

Antonytm commented 2 years ago

Hi @markgibbons25

I see your commit message: "Avif support. Only works on async mode at the moment, some issue with CDN sync mode." Just for my curiosity, what issue do you have? (I checked CDN sync mode and it seems work fine after small change in MediaRequestHandler similar to MediaRequestHandlerXA)

markgibbons25 commented 2 years ago

If it's working for you then I'm happy to merge a pr, ideally with some refactoring to allow other modules such as when jpegxl gets adopted. Only chrome supports avif though and it doesn't provide much benefit over webp. if you can do regression testing too that would be appreciated. Needs documentation etc. Thanks for looking into this.

On Fri, 31 Dec 2021, 10:02 pm Antonytm, @.***> wrote:

Hi @markgibbons25 https://github.com/markgibbons25

I see your commit message: "Avif support. Only works on async mode at the moment, some issue with CDN sync mode." Just for my curiosity, what issue do you have? (I checked CDN sync mode and it seems work fine after small change in MediaRequestHandler similar to MediaRequestHandlerXA)

— Reply to this email directly, view it on GitHub https://github.com/kamsar/Dianoga/issues/89#issuecomment-1003358566, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAYQJ5T26F4YKHYCVYLBXUTUTWLVLANCNFSM4Z4WEQ4A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

Antonytm commented 2 years ago

Hi @markgibbons25

There was done refactoring to allow easier enabling usage on new next-gen formats. And I have added JPEG XL optimization to make sure that now it becomes easier.

Can you please take a look at this PR and let me know your thoughts? https://github.com/kamsar/Dianoga/pull/100

markgibbons25 commented 2 years ago

Many thanks, released in v6.