`kamu version`: Vergen generation failure for `Linux / amd64 / musl`

s373r commented 3 weeks ago

Describe the bug

This regression was noticed in https://github.com/kamu-data/kamu-cli/actions/runs/10505067423/job/29102733887

According to a quick analysis, the default values are set in case of an error (based on https://github.com/rustyhorde/vergen/issues/216#issuecomment-1587418024)

Steps To Reproduce

https://github.com/kamu-data/kamu-cli/actions/runs/10505067423/job/29102733887

Current Behavior

{
  "appVersion": "0.197.0",
  "buildTimestamp": "2024-08-22T08:40:44.340464232Z",
  "gitDescribe": "3009ff0",
  "gitSha": "3009ff0ad832ad7f0982da25043bb0d8e9539d4a",
  "gitCommitDate": "2024-08-22",
  "gitBranch": "HEAD",
  "rustcSemver": "1.81.0-nightly",
  "rustcChannel": "nightly",
  "rustcHostTriple": "x86_64-unknown-linux-gnu",
  "rustcCommitSha": "8337ba9189de188e2ed417018af2bf17a57d51ac",
  "cargoTargetTriple": "VERGEN_IDEMPOTENT_OUTPUT",
  "cargoFeatures": "VERGEN_IDEMPOTENT_OUTPUT",
  "cargoOptLevel": "VERGEN_IDEMPOTENT_OUTPUT"
}

Expected Behavior

{
  ...
  "cargoTargetTriple": "<INSERTED VALUE>",
  "cargoFeatures": "<INSERTED VALUE>",
  "cargoOptLevel": "<INSERTED VALUE>"
}

kamu system info

Logs

No response

Anything else?

The previous release (0.196.0) works fine (https://github.com/kamu-data/kamu-cli/actions/runs/10452413434/job/28940778741)

sergiimk commented 3 weeks ago

Let's re-enable fail_on_error behavior in vergen so that we don't produce invalid builds

s373r commented 2 weeks ago

For the record: there was no error in the last build: https://github.com/kamu-data/kamu-cli/actions/runs/10580660385

kamu-data / kamu-cli

`kamu version`: Vergen generation failure for `Linux / amd64 / musl` #789