Closed DrWelles closed 1 year ago
@kan-bayashi Hi Tomoki, as I mentioned to you days back, this is the implementation for a singing-specific vocoder. Could you please take a look to see if it fits into the repo? Many thanks!
Sorry for late reply, and thank you for your great PR. I am a little bit busy in this month, I will check and revise when I finished my tasks...
Now I almost finished my jobs in this fiscal year! Sorry for too late reviewing. I will check and refactor this PR in this weekend.
@DrWelles I refactored your PR (see #402) If your branch seems master, so I'm wondering to push my changes to your repo. Is it OK?
@DrWelles I refactored your PR (see #402) If your branch seems master, so I'm wondering to push my changes to your repo. Is it OK?
Sure
Thanks. I listed some points of my changes.
evaluate_*.py
) and locate it in bin
uhifigan_single.py
since it seems not used. Is it OK?Thanks. I listed some points of my changes.
- I modified your codes to be compatible with all modes
- I removed duplicated codes (
evaluate_*.py
) and locate it inbin
- I added debug recipe of uhifigan for yesno
- I removed debug loggings
- I removed
uhifigan_single.py
since it seems not used. Is it OK?
Great! And it's OK to remove uhifigan_single.py. :)
Thank you so much for your great feature & sorry for late merging!