search

kan-bayashi / ParallelWaveGAN

Unofficial Parallel WaveGAN (+ MelGAN & Multi-band MelGAN & HiFi-GAN & StyleMelGAN) with Pytorch
https://kan-bayashi.github.io/ParallelWaveGAN/
MIT License
1.54k stars 339 forks source link

Refactor HiFi-GAN Conv1d padding with `same` arg #396

Closed tarepan closed 1 year ago

tarepan commented 1 year ago

resolve #395

tarepan commented 1 year ago

Test failed because of PyTorch version. Old PyTorch do not support same argument.

I have forgotten this fact...
Are there any policy about PyTorch version in this repository?
For example, "support PT1.4 as long as we can".

kan-bayashi commented 1 year ago

@tarepan Thank you for your kind summary and PR. padding=same is useful, but it is available in only recent pytorch. I want to keep the compatibility with older version. Therefore, I could not merge this PR. Anyway, Thank you for your good suggestions.

kan-bayashi commented 1 year ago

It seems padding same is available from 1.8.

kan-bayashi commented 1 year ago

Are there any policy about PyTorch version in this repository?

At least, I want to keep the old version which supported in espnet.

tarepan commented 1 year ago

I understand the situation.
Thanks for your kind review!