Closed tarepan closed 1 year ago
Test failed because of PyTorch version. Old PyTorch do not support same
argument.
I have forgotten this fact...
Are there any policy about PyTorch version in this repository?
For example, "support PT1.4 as long as we can".
@tarepan Thank you for your kind summary and PR. padding=same is useful, but it is available in only recent pytorch. I want to keep the compatibility with older version. Therefore, I could not merge this PR. Anyway, Thank you for your good suggestions.
It seems padding same is available from 1.8.
Are there any policy about PyTorch version in this repository?
At least, I want to keep the old version which supported in espnet.
I understand the situation.
Thanks for your kind review!
resolve #395