search

kanaka / mal

mal - Make a Lisp
Other
10k stars 2.53k forks source link

Test empty string #621

Closed bbarker closed 3 weeks ago

bbarker commented 1 year ago

At least, I think this should be a valid test. I've not tried it yet.

bbarker commented 1 year ago

Looks like the test-runner needs to be changed too

kanaka commented 3 weeks ago

@bbarker Sorry for the really slow response. I'm going to close this PR at this point. In addition to requiring modifications to runtest.py, not all implementations necessarily have the same behavior around empty lines (whether prompt is printed again, whether it's considered an error, etc).

bbarker commented 3 weeks ago

Got it, thanks!

On Sat, Aug 10, 2024 at 10:58 AM Joel Martin @.***> wrote:

Closed #621 https://github.com/kanaka/mal/pull/621.

— Reply to this email directly, view it on GitHub https://github.com/kanaka/mal/pull/621#event-13828059973, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAG7XDX55RR753CTQ46SDWTZQYS75AVCNFSM6AAAAABMJI4HFSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTHAZDQMBVHE4TOMY . You are receiving this because you were mentioned.Message ID: @.***>

-- Brandon Barker @.***